-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Disable Hardware Authenticator identities for unsupported Networks #140
feat: Disable Hardware Authenticator identities for unsupported Networks #140
Conversation
✅ Deploy Preview for lifted-alberto ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov Report
@@ Coverage Diff @@
## main #140 +/- ##
==========================================
+ Coverage 33.82% 34.35% +0.52%
==========================================
Files 89 89
Lines 2282 2308 +26
Branches 655 659 +4
==========================================
+ Hits 772 793 +21
- Misses 1499 1504 +5
Partials 11 11
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Looking into CI failures. I think it's a package that was updated in |
Okay, should look pretty similar to liftedinit/gwen#75. Reviews welcome. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
@jgryffindor can we deploy in QA, please? Thanks!
I can't create a new HSM account on QA. @jgryffindor is this an infra or an Alberto issue? |
I'm getting the same result. The release is out in QA so if there aren't any new infra requirements for this feature then it's something in the release. |
@stanleyjones I don't think the issue I reported above is related to this PR. I will investigate. Could you start working on #142 ? |
Fixed in #147 |
Tested in QA, everything LGTM. Thanks @stanleyjones |
See liftedinit/gwen#75
Closes #135