Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Disable Hardware Authenticator identities for unsupported Networks #140

Merged
merged 20 commits into from
Oct 12, 2023

Conversation

stanleyjones
Copy link
Contributor

@stanleyjones stanleyjones commented Sep 14, 2023

@netlify
Copy link

netlify bot commented Sep 14, 2023

Deploy Preview for lifted-alberto ready!

Name Link
🔨 Latest commit cd3d1e3
🔍 Latest deploy log https://app.netlify.com/sites/lifted-alberto/deploys/65280a7e1967350008037e3e
😎 Deploy Preview https://deploy-preview-140--lifted-alberto.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Merging #140 (cd3d1e3) into main (de373d2) will increase coverage by 0.52%.
The diff coverage is 83.33%.

@@            Coverage Diff             @@
##             main     #140      +/-   ##
==========================================
+ Coverage   33.82%   34.35%   +0.52%     
==========================================
  Files          89       89              
  Lines        2282     2308      +26     
  Branches      655      659       +4     
==========================================
+ Hits          772      793      +21     
- Misses       1499     1504       +5     
  Partials       11       11              
Files Coverage Δ
...nts/components/accounts-menu/add-account-modal.tsx 98.21% <90.90%> (+0.13%) ⬆️
...ccounts/components/accounts-menu/accounts-menu.tsx 88.00% <77.77%> (-2.48%) ⬇️
src/features/network/network-provider.tsx 91.42% <81.25%> (-8.58%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@stanleyjones
Copy link
Contributor Author

Looking into CI failures. I think it's a package that was updated in main but not this branch.

@stanleyjones
Copy link
Contributor Author

Okay, should look pretty similar to liftedinit/gwen#75. Reviews welcome.

Copy link
Contributor

@fmorency fmorency left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jgryffindor can we deploy in QA, please? Thanks!

@fmorency
Copy link
Contributor

I can't create a new HSM account on QA. @jgryffindor is this an infra or an Alberto issue?

2023-10-11_10-08

@jgryffindor
Copy link

I'm getting the same result. The release is out in QA so if there aren't any new infra requirements for this feature then it's something in the release.

@fmorency
Copy link
Contributor

@stanleyjones I don't think the issue I reported above is related to this PR. I will investigate.

Could you start working on #142 ?

@fmorency
Copy link
Contributor

Fixed in #147

@fmorency
Copy link
Contributor

Tested in QA, everything LGTM. Thanks @stanleyjones

@fmorency fmorency merged commit c65b4a1 into liftedinit:main Oct 12, 2023
10 checks passed
@stanleyjones stanleyjones deleted the disable-hardware-authenticator branch December 6, 2023 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disable Hardware Authenticator entry if neighborhood doesn't support it
3 participants